Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBAN conversion validation #588

Merged
merged 7 commits into from
Aug 3, 2016
Merged

Fix IBAN conversion validation #588

merged 7 commits into from
Aug 3, 2016

Commits on Jul 28, 2016

  1. Fix IBAN conversion validation

    The forms were sending empty fields to the server, sometimes even
    incorrect fields (See https://phabricator.wikimedia.org/T141381). This
    was introduced by #568,
    which was not the correct fix for the issue.
    gbirke committed Jul 28, 2016
    Configuration menu
    Copy the full SHA
    a8f659d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2016

  1. Configuration menu
    Copy the full SHA
    f6c2b02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    646dcc9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dfed74e View commit details
    Browse the repository at this point in the history
  4. Merge pull request #591 from wmde/ohmygawd-ididajs

    Reduced state and made checks more explicit in BankDataValidator
    gbirke authored Jul 29, 2016
    Configuration menu
    Copy the full SHA
    e3f6c6d View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2016

  1. Mark private JS methods

    gbirke committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    0702005 View commit details
    Browse the repository at this point in the history
  2. Add Validation states

    Apart from the `OK` and `ERR` states we had `INCOMPLETE`. `Now they are
    all bundled up in a value object.
    
    For the bank data validation the state `NOT_APPLICABLE` was added to
    avoid sending data to the server and changing the validation state when
    a different payment method thank direct debit is selected.
    gbirke committed Aug 1, 2016
    Configuration menu
    Copy the full SHA
    c48f8c0 View commit details
    Browse the repository at this point in the history