-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of space weather schemas and examples #84
Conversation
I have several observations:
|
@blchoy - thanks for the review.
|
Per Choy's comment. This is now consistent with AIRMET and SIGMET. Improved description as well
Note that the current build failures are due to the fact that the proposed WMO Codes List entries don't exist yet. @marqh are you able to look at this? The proposed code registries are described at #50 (comment), we cannot close this issue until these entries are decided (although it could take longer for them to be added to the live instance) |
With regard to your suggestions:
|
Going back to the Annex descriptions, SWAs have the following options for "expected time of issuance of next advisory":
VAA has the following options for "next advisory":
My take is that option 2 and option 3 of VAA have the same meaning (I believe I emailed ICAO on this recently) and therefore that VAA and SWA have essentially the same intent: either a specific time of issuance or a time before which the next issuance will occur. The current representation allows this to be reported as both nextAdvisoryLatestTime and nextAdvisoryEarliestTime are optional - when there is a specific time being reported they are both present and set to the same time and when there is a "BEFORE" being reported only the nextAdvisoryLatestTime is present. I'm not sure that the TimePeriod/TimeInstant mechanism really captures the correct semantics: for a specific time this would be represented with the nextAdvisoryTime as a TimeInstant - for the "BEFORE" case there isn't a clear way to represent it. For this and for VAA backwards compatibility reasons I think we are better keeping the current, independent TimeInstants. |
Alright. Seems that we have to accept this for the time being. :) |
No description provided.