Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Blake3's derive_key algorithm instead of SHA3 #69

Merged
merged 14 commits into from
Aug 11, 2023

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Jul 17, 2023

  • Use Blake3 instead of SHA3 everywhere
  • Use the derive_key algorithm from blake3 (see the specification) if applicable
  • Introduce some domain separation strings to use with derive_key
  • Adjust the way external file content blocks are linked to skip a lot of work.

merge order

  1. Update rsa modulus endianess to match most protocols #66
  2. Remove namefilter.md and add NameAccumulator verification algorithm #68
  3. This PR
  4. Switch from AES-GCM to XChaCha20-Poly1305 #70
  5. Add baseName to ExternalContent #71

@matheus23 matheus23 self-assigned this Jul 17, 2023
@matheus23 matheus23 requested a review from expede as a code owner July 17, 2023 17:06
@cla-bot cla-bot bot added the cla-signed label Jul 17, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we should probably use the all-caps BLAKE3, as that's the algorithm name

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what happened to he font size? Super minor, but I think the larger font was easier to read (bigger is almost always beter, espeically with colour)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Font size changed because tldraw version was updated :/
I'd need to rework the diagrams a bit and resize stuff to have better proportions. But yeah, that's what I get for using the beta 🙃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish Mermaid had more control over layout, but 🤷‍♀️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the BLAKE3 spelling, but I hope it's okay if I postpone the diagram adjustments.
It takes quite a while creating these diagrams, and there's a bunch of things that should be done at the same time, that includes switching over to one consistent style for diagrams for example.

spec/notation.md Outdated Show resolved Hide resolved
spec/private-wnfs.md Outdated Show resolved Hide resolved
spec/nameaccumulator.md Outdated Show resolved Hide resolved
spec/private-wnfs.md Outdated Show resolved Hide resolved
Copy link
Member

@expede expede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1,052 −1,191

LOL I guess TLDraw makes big diffs

Just a couple minor suggestions, but otherwise looks good :)

Base automatically changed from matheus23/remove-namefilter to main August 11, 2023 14:38
@matheus23 matheus23 merged commit 41f7906 into main Aug 11, 2023
1 check passed
@matheus23 matheus23 deleted the matheus23/blake3-derive-key branch August 11, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants