-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Blake3's derive_key
algorithm instead of SHA3
#69
Conversation
spec/diagrams/node_key_layout.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we should probably use the all-caps BLAKE3
, as that's the algorithm name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what happened to he font size? Super minor, but I think the larger font was easier to read (bigger is almost always beter, espeically with colour)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Font size changed because tldraw version was updated :/
I'd need to rework the diagrams a bit and resize stuff to have better proportions. But yeah, that's what I get for using the beta 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish Mermaid had more control over layout, but 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the BLAKE3 spelling, but I hope it's okay if I postpone the diagram adjustments.
It takes quite a while creating these diagrams, and there's a bunch of things that should be done at the same time, that includes switching over to one consistent style for diagrams for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
derive_key
algorithm from blake3 (see the specification) if applicablederive_key
❗ merge order ❗
namefilter.md
and addNameAccumulator
verification algorithm #68AES-GCM
toXChaCha20-Poly1305
#70baseName
toExternalContent
#71