docs: Add mention of the parent folder #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was going through the instructions today and noticed that for a newbie putting the `argo-ui` folder in the same parent folder as the rest of the Argo components might not be super-obvious and could be mentioned on the 1st step rather than the 4th one.
wojtekidd
pushed a commit
that referenced
this pull request
Apr 22, 2022
* chore: update grpc POC Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix: register gogo codec (#1) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Remove gogo annotations from application.proto Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix unit tests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix e2e test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix lint Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix lint Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix unit-test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix LogEntry.Last required field not populated Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix LogEntry required fields Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix get log content Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix app actions list Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix ApplicationPodLogsQuery Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix RunResourceAction Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
wojtekidd
pushed a commit
that referenced
this pull request
Apr 25, 2022
* chore: update grpc POC Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * fix: register gogo codec (#1) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Remove gogo annotations from application.proto Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix unit tests Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix e2e test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix lint Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix lint Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix unit-test Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix LogEntry.Last required field not populated Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix LogEntry required fields Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix get log content Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix app actions list Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix ApplicationPodLogsQuery Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> * Fix RunResourceAction Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the instructions today and noticed that for a newbie putting the
argo-uifolder in the same parent folder as the rest of the Argo components might not be super-obvious and could be mentioned on the 1st step rather than the 4th one.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: