Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for padding in session tickets #4908

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Mar 1, 2022

Description

Adds padding based on WOLFSSL_GENERAL_ALIGNMENT. Increases enc_len to 32-bit.

Related to PR #4887

Testing

./configure --enable-session-ticket CFLAGS="-DWOLFSSL_GENERAL_ALIGNMENT=4" && make check

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev
Copy link
Contributor

Isn't word32 meant to be 4-byte unsigned integer on all platforms?

@dgarske
Copy link
Contributor Author

dgarske commented Mar 1, 2022

Isn't word32 meant to be 4-byte unsigned integer on all platforms?

Yes, is that an issue? Trying to better align the struct by using 4 bytes there.

@SparkiDev
Copy link
Contributor

I didn't think it was 2 bytes before! Thanks!!

src/internal.c Show resolved Hide resolved
…NERAL_ALIGNMENT`. Increases `enc_len` to 32-bit. Related to PR wolfSSL#4887
@dgarske dgarske assigned SparkiDev and unassigned dgarske Mar 2, 2022
@SparkiDev SparkiDev merged commit 59970d9 into wolfSSL:master Mar 2, 2022
@dgarske dgarske deleted the tick_pad branch March 9, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants