Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy branches #167

Open
rockt opened this issue Oct 21, 2015 · 3 comments
Open

Delete legacy branches #167

rockt opened this issue Oct 21, 2015 · 3 comments
Assignees

Comments

@rockt
Copy link
Member

rockt commented Oct 21, 2015

Would be good if we could clean up legacy branches and follow a more structured git branching model like http://nvie.com/posts/a-successful-git-branching-model/

@rockt rockt self-assigned this Oct 21, 2015
@riedelcastro
Copy link
Contributor

All in favour of a cleanup! I already removed quite a few at some point, but there are still a lot I didn't know what to do with...

@rockt
Copy link
Member Author

rockt commented Oct 22, 2015

Maybe the following can go...

  • lawrap since it's replaced by Tensor Wrapper #162
  • ner-exapmle seems to be extremely old but maybe there is still something to learn from how we approached it back then... interesting to see that we came up with mystical operators back then ~~ or |->
  • deep-learning also subsumed by Tensor Wrapper #162 and the new terms but @mbosnjak should have a look if he wants to keep some of this code around

I am unsure about these...

  • CompetitiveNER I think @insperatum made quite a progress on the Junction Tree Algorithm there and I am not sure what we might want to reuse or whether that code made its way into dev at some point
  • ocsvm should maybe stay since there is some convex MF code that Johannes or Guillaume might find useful
  • TokenFun a branch by @watercrossing and I am not sure what the status is. Is this useful for wolfe-nlp?
  • AAAI also a very old branch. Not sure there is anything reusable in there

Thoughts?

@narad
Copy link
Contributor

narad commented Oct 22, 2015

I would keep the TokenFun branch around because the ideas Sebastian and I
have been throwing around for wolfe-nlp are very closely related to the
intent Ingolf had when he was working on this back during the ol'
hackathon. I pinky-promise to delete it myself when we've carried it all
over or at least have had a good look at progress made there.

Cheers,
Jason

On Thu, Oct 22, 2015 at 8:30 PM, Tim Rocktäschel notifications@github.com
wrote:

Maybe the following can go...

I am unsure about these...

  • CompetitiveNER I think @insperatum https://github.com/insperatum
    made quite a progress on the Junction Tree Algorithm there and I am not
    sure what we might want to reuse or whether that code made its way into
    dev at some point
  • ocsvm should maybe stay since there is some convex MF code that
    Johannes or Guillaume might find useful
  • TokenFun a branch by @watercrossing
    https://github.com/watercrossing and I am not sure what the status
    is. Is this useful for wolfe-nlp?
  • AAAI also a very old branch. Not sure there is anything reusable in
    there

Thoughts?


Reply to this email directly or view it on GitHub
#167 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants