Handle OSError exception from format_time() in ETA.__call__() #298
Conversation
In Windows CPython, format_time() can throw "OSError: [Errno 22] Invalid argument" when passed a very large date. Ignore this in ETA.__call__() with contextlib.suppress(). Fixes wolph#297.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I don't see an alternative fix in develop. Bug report rejected? |
|
I still haven't configured the stupid stalebot correctly it seems... in any case, the fix hasn't been deployed yet, the last update was a question from my end:
But I'll merge it and create a new release regardless, thank you for the help! |
|
Hmmm…I don’t remember seeing that question. I’ll take a look and respond tomorrow. Sorry for the delay.
— John
… On Aug 17, 2024, at 8:50 PM, Rick van Hattem ***@***.***> wrote:
I still haven't configured the stupid stalebot correctly it seems... in any case, the fix hasn't been deployed yet, the last update was a question from my end:
image.png (view on web) <https://github.com/user-attachments/assets/d0a7d0ae-b2a8-4853-88db-c39d2644eeb1>
But I'll merge it and create a new release regardless, thank you for the help!
—
Reply to this email directly, view it on GitHub <#298 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMPDXAJDUXA35342PK2TWTZR74WBAVCNFSM6AAAAABIUPAT4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGA2TQMRTGQ>.
You are receiving this because you authored the thread.
|
|
No worries... I regularly don't get mail from Github's notifications either. Not sure if it's a spam filter or something else, but it's been bothering me for years. |
|
See above response to June 1 static checking bot. |
|
Thank you so much for the fix! I've created a new release but I'm still (slowly...) working on updating the CI builds again so all automated testing works 100% again. But that takes a lot of time and effort :) |
FYI, you never submitted the review with the pictured comment ( it even says so in the screenshot, with the label "Pending" on it ) |
It seems you're right... in my mind I had only commented and not started a full review. I've been rather sleep deprived lately, I'm probably going to automate the entire release process to prevent these things from happening in the future since this was just stupidity on my part. |
In Windows CPython, format_time() can throw "OSError: [Errno 22] Invalid argument" when passed a very large date. Ignore this in ETA.call() with contextlib.suppress(). Fixes #297.