Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.5.1 #2034

Merged
merged 68 commits into from
Aug 1, 2023
Merged

release 2.5.1 #2034

merged 68 commits into from
Aug 1, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 1, 2023

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.5.1
    git checkout release/2.5.1
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.5.1  --wp_tested=6.2.2 --wc_tested=7.9.0 --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.1
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.5.1  --wp_tested=6.2.2 --wc_tested=7.9.0  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.5.1
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.5.1, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (if applicable for this repo).

andyg2 and others added 30 commits July 3, 2023 19:11
Provides the ability to control the product selection of synced products.
Add apply_filters hook to prepare_query_args
…n from `CampaignAssetsForm` to `AdaptiveForm`
…or `SetupFreeListings` and the relevant components
…nd `formProps` for `StoreRequirements` and the relevant components
…ding state of submit button in `SetupFreeListings` and `StoreRequirements`
…tupFreeListings` and the relevant components
Release 2.5.0 - Merge trunk into develop
…tion-request

Move the verification request from `CampaignAssetsForm` to `AdaptiveForm`
Apply `AdaptiveForm` and its abilities to steps 2 and 3 of the onboarding flow for higher code consistent
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Ability to control the product selection of synced products
…d-wrap-1.2.4

Bump word-wrap from 1.2.3 to 1.2.4
eason9487 and others added 26 commits July 26, 2023 16:00
…e-validation-errors-step-2

Show validation errors on step 2 of the onboarding flow when unable to continue
…e-validation-errors-step-3

Show validation errors on step 3 of the onboarding flow when unable to continue
…er-card

Add JavaScript tests for the `PhoneNumberCard` component
…er-contents

Add JavaScript tests for the `EditPhoneNumberContent` and `VerifyPhoneNumberContent` components
Add To Cart Tracking support for Products (Beta) Block
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2034 (d321bb5) into trunk (afebc1e) will increase coverage by 0.2%.
Report is 52 commits behind head on trunk.
The diff coverage is 81.8%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             trunk   #2034     +/-   ##
=========================================
+ Coverage     57.9%   58.1%   +0.2%     
- Complexity    4111    4119      +8     
=========================================
  Files          456     455      -1     
  Lines        17658   17695     +37     
=========================================
+ Hits         10224   10278     +54     
+ Misses        7434    7417     -17     
Flag Coverage Δ
php-unit-tests 58.1% <81.8%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
google-listings-and-ads.php 6.4% <0.0%> (ø)
src/API/Google/AdsAssetGroupAsset.php 84.8% <0.0%> (ø)
src/API/Google/AdsCampaignCriterion.php 100.0% <ø> (ø)
src/API/Google/AdsConversionAction.php 97.6% <ø> (ø)
src/API/Google/Connection.php 1.6% <ø> (ø)
src/API/Google/Middleware.php 85.7% <ø> (ø)
src/Admin/MetaBox/ChannelVisibilityMetaBox.php 0.0% <0.0%> (ø)
...c/Admin/MetaBox/CouponChannelVisibilityMetaBox.php 0.0% <0.0%> (ø)
src/Admin/Product/Attributes/AttributesTab.php 0.0% <0.0%> (ø)
src/MerchantCenter/ContactInformation.php 100.0% <ø> (ø)
... and 12 more

@martynmjones
Copy link
Contributor

martynmjones commented Aug 1, 2023

[Add] New Features 🎉

[Update] Updated ✨

[Fix] Fixes 🛠

[Dev] Developer-facing changes 🧑‍💻

@martynmjones martynmjones merged commit fa2a652 into trunk Aug 1, 2023
14 of 15 checks passed
@martynmjones martynmjones deleted the release/2.5.1 branch August 1, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants