Allow curl to follow redirects #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some WooCommerce stores return a redirect for api calls where the query string with the credentials (consumer_key and consumer_secret) is included in the url.
For example
https://my-store.com?consumer_key=x&consumer_secret=ywill return a redirect tohttps://my-store.com/?consumer_key=x&consumer_secret=y. Since the curl object is not setting the curl optCURL_FOLLOWLOCATIONit will just return the html response and will also trigger a syntax error due to the failure to decode the JSON.What this PR solves
If the WooCommerce client is configured to follow redirect than any 301 will just work without needing to adjust the URL. I would think that this should be a default option but I guess it's a good idea to leave it optional as well.