Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when underlining special Glyph in Aztec #11883

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

itsmeichigo
Copy link
Contributor

Closes: #11866

Description

This PR updates Aztec library to include the crash fix when underlining text with special glyphs.

Testing instructions

  • In wp-admin, open an existing product or create a new one.
  • In the product description field, switch the classic editor to the text mode and enter some link with special glyphs like this and save the product.
<a href="https://example.com/">&nbsp;قسم شنط &nbsp;الكايلي &nbsp;</a>

<a href="https://www.wordpress.com/"><img class="alignnone wp-image-65" title="شنطة كايلي" src="https://www.wordpress.com/" alt="لوقو انستجرام" width="40" height="40" data-image-description="&lt;/p&gt; &lt;p&gt;لوقو انستجرام&lt;/p&gt; &lt;p&gt;" /></a>
  • Open the app and select the updated product.
  • Select product description and confirm that the app doesn't crash. The text link should be underlined correctly.

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: crash The worst kind of bug. feature: add/edit products Related to adding or editing products. labels Feb 2, 2024
@itsmeichigo itsmeichigo added this to the 17.2 milestone Feb 2, 2024
@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 17.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr11883-4730118
Version17.1
Bundle IDcom.automattic.alpha.woocommerce
Commit4730118
App Center BuildWooCommerce - Prototype Builds #7894
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@selanthiraiyan selanthiraiyan self-assigned this Feb 2, 2024
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. This works as expected. 🚀


An observation not related to this PR

The product description text in the product details form screen is not underlined.
Simulator Screen Recording - iPhone 15 Pro Max - 2024-02-02 at 13 20 51

@itsmeichigo
Copy link
Contributor Author

The product description text in the product details form screen is not underlined.

This is expected, we are not handling styles there.

@itsmeichigo itsmeichigo merged commit 945b523 into trunk Feb 2, 2024
27 of 33 checks passed
@itsmeichigo itsmeichigo deleted the issue/11866-fix-crash-aztec-underline branch February 2, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: add/edit products Related to adding or editing products. type: crash The worst kind of bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSRangeException: Aztec.TextStorage attributedSubstringFromRange:: Out of bounds
4 participants