Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Dashboard: Various states and tracking for Reviews card #12787

Conversation

hafizrahman
Copy link
Contributor

@hafizrahman hafizrahman commented May 20, 2024

Closes: #12742

Description

This PR completes the Reviews card task by adding the following:

  1. Updates loading behavior to:
    1. prefer fetching local review data first and show it, if available,
    2. show partial review data if fetched data becomes available even before fetching product name or notifications
  2. Finalizing UI for loading state,
  3. UI for error state,
  4. UI for empty state (both for when there's no reviews at all in the site, and when there's no reviews after filtering)
  5. Trackings

Testing instructions

Screenshots

Error case:

Empty state case: absolutely no reviews Empty state case: no filtered reviews
Simulator Screenshot - iPhone 15 iOS 17 4 - 2024-05-22 at 09 42 07 Simulator Screenshot - iPhone 15 iOS 17 4 - 2024-05-20 at 16 47 53
Loading state case: no reviews ever loaded Loading state case: some reviews were shown before
Simulator Screenshot - iPhone 15 iOS 17 4 - 2024-05-20 at 16 54 32 Simulator Screenshot - iPhone 15 iOS 17 4 - 2024-05-20 at 16 54 21

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 20, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12787-780f817
Version18.7
Bundle IDcom.automattic.alpha.woocommerce
Commit780f817
App Center BuildWooCommerce - Prototype Builds #9156
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@hafizrahman
Copy link
Contributor Author

Closing in favor of #12806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants