This repository was archived by the owner on Jul 6, 2025. It is now read-only.
Fix compatibility for WP 5.5 #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple of changes in response to https://core.trac.wordpress.org/changeset/48306
mixed
is now changed to appropriate scalar type with addition ofnull
. So final type is nowarray( {scalar}, 'null' )
.array
,string
,null
, and if an array, then allowed item type isstring
ornull
. This means that only one of nesting is now allowed for WooCommerce settings via API. Would appreciate the feedback here on if this is backward compatible or not. Looks like we have to mandatorily define the child properties if the native property is array or object. This means that just saying that type isobject
is not allowed, we have to define all the properties of children (and their children, etc if any).type => date-time
totype => string, format => date-time
.