This repository was archived by the owner on Jul 6, 2025. It is now read-only.
[WC 4.3] Port over fixes from Core for API BW #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cc96f6bbd19f3b007e1f8e01932bfc6846490b60.
This prop was missed in an earlier commit.
Add test for null meta value as well Add test for variation v2 controller for complex meta object Add test for update in date-time field Add a explicit test for null as well
vedanshujain
force-pushed
the
fix/4.3.2/27282
branch
from
5911286 to
952567e
Compare
vedanshujain
force-pushed
the
fix/4.3.2/27282
branch
from
f42aa5f to
e4907d4
Compare
|
Looks like test were failing because WooCommerce REST API was loading from package instead of the plugin. I have pushed a version bump commit to see if that resolves. |
Konamiman
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #238 , this PR port over changes for WC 4.3.3 and closes woocommerce/woocommerce/issues/27282.