Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly link commit hash in run UI #2657

Closed
5 tasks done
pat-s opened this issue Oct 27, 2023 · 1 comment · Fixed by #3368
Closed
5 tasks done

Properly link commit hash in run UI #2657

pat-s opened this issue Oct 27, 2023 · 1 comment · Fixed by #3368
Labels
bug Something isn't working ui frontend related
Milestone

Comments

@pat-s
Copy link
Contributor

pat-s commented Oct 27, 2023

Component

web-ui

Describe the bug

From https://codeberg.org/Codeberg-CI/feedback/issues/91

A commit hash link in CRON runs only links to user/repo instead of user/repo/commit/xxx

image

System Info

next-7b3eeec65c # Oct 17

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@pat-s pat-s added bug Something isn't working ui frontend related labels Oct 27, 2023
@pat-s pat-s mentioned this issue Nov 1, 2023
@anbraten
Copy link
Member

anbraten commented Nov 3, 2023

Should be related to

Link: repo.Link,
}, nil

Afaik we don't know the link to the commit at that place and probably use the "wrong" link because of that.

@qwerty287 qwerty287 added this to the 2.x.x milestone Feb 10, 2024
@qwerty287 qwerty287 modified the milestones: 2.x.x, 2.4.0 Feb 11, 2024
qwerty287 added a commit that referenced this issue Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants