Skip to content

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Oct 6, 2025

What?

Ensure theme styles supersede default styles.

Why?

Fix CMM-825.

When enabled, theme styles should take precedence over default styles.
Otherwise, it negates the "Apply theme styles" feature altogether.

How?

Relocate default global CSS variables so they are only loaded when theme
styles are disabled. Otherwise, due to the load order of stylesheets,
these default variables overrode theme style variables.

Testing Instructions

  1. Install and activate the Kanso theme for your site.
  2. Enable the "theme styles" for the experimental editor.
  3. Open the experimental editor.
  4. Verify the font size is correct for the post title and placeholder paragraph
    text.

Accessibility Testing Instructions

N/A, no navigation changes.

Screenshots or screencast

Before After
before after

Relocate default global CSS variables so they are only loaded when theme
styles are disabled. Otherwise, due to the load order of stylesheets,
these default variables overrode theme style variables.
@dcalhoun dcalhoun added the [Type] Bug An existing feature does not function as intended label Oct 6, 2025
@dcalhoun dcalhoun marked this pull request as ready for review October 6, 2025 14:30
@dcalhoun dcalhoun requested a review from kean October 6, 2025 14:31
@dcalhoun dcalhoun enabled auto-merge (squash) October 6, 2025 14:31
@dcalhoun dcalhoun merged commit b21dd88 into trunk Oct 6, 2025
11 checks passed
@dcalhoun dcalhoun deleted the fix/theme-styles-supersede-default-styles branch October 6, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants