Show an card to prompt application password authentication #24561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27808 | |
| Version | PR #24561 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | bcad039 | |
| Installation URL | 2gkq9eugsit1o |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27808 | |
| Version | PR #24561 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | bcad039 | |
| Installation URL | 7ka44s0cc3jpo |
crazytonyli
force-pushed
the
comments-backed-by-wordpress-rs
branch
from
38dff55 to
8e51c99
Compare
crazytonyli
force-pushed
the
site-rest-api-via-wpcom
branch
from
71236d7 to
2733ea7
Compare
crazytonyli
commented
May 27, 2025
|
|
||
| if let site = try? WordPressSite(blog: blog) { | ||
| return MediaServiceRemoteCoreREST(client: .init(site: site)) | ||
| } |
There was a problem hiding this comment.
Just a reminder to myself that we'll keep the original implementation for media, where we prefer the WP.com API over the REST API.
crazytonyli
force-pushed
the
site-rest-api-via-wpcom
branch
from
63314b5 to
aa71a8d
Compare
So that the new application password can be added to the blog
Only available when the "Application Passwords for self-hosted sites" feature flag is on. The feature flag is available as one of the "Experimental Features".
crazytonyli
force-pushed
the
site-rest-api-via-wpcom
branch
from
2a0dc27 to
88e4269
Compare
jkmassel
approved these changes
May 29, 2025
There was a problem hiding this comment.
This LGTM, though we should ask Jetpack to make an Application Password for us. There's an API for that, but we should only use it if the background auto discovery works.
I think we'll need to add support for that API to wordpress-rs first in the jetpack namespace.
crazytonyli
commented
May 29, 2025
| return CommentServiceRemoteREST(wordPressComRestApi: api, siteID: dotComID) | ||
| } | ||
|
|
||
| // The REST API does not have information about comment "likes". We'll continue to use WordPress.com API for now. |
There was a problem hiding this comment.
@jkmassel FYI, I have reverted the comment API changes, due to lack of "likes" support in the REST API.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR touched quite a few areas. It might be easier to review this PR commit by commit.
Description
This PR adds a card to the blog details screen to ask users to authenticate with application passwords. This card is only available when the "Application Passwords for self-hosted sites" feature flag/experimental feature is enabled.
Once an application password is authorized to the app, comments and media use it to talk directly to the site via REST API.
This card will show up on all self-hosted sites, with or without WP.com account. Here are a couple of recordings:
⬇️ Site outside of WP.com
self-hosted-sites.mp4
⬇️ Sites within WP.com
wp-com-sites.mp4
Testing instructions
Enable the "Application Passwords for self-hosted sites" feature flag and test the new card on vanilla sites and sites that are connected to WP.com.