Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gutenberg hash for contact info inner blocks bugfix #3071

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

illusaen
Copy link
Contributor

Updates gutenberg hash for contact info inner blocks change.

Gutenberg PR: #28569

To test:

  1. Open app and insert contact info block.
  2. Verify that contact info block has email/address/phone inner blocks by default.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 29, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@illusaen illusaen force-pushed the fix-contact-info-inner-blocks branch from c576b6a to 1c40e44 Compare February 1, 2021 19:58
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#28569 (review). Feel free to merge after updating reference to gutenberg master branch: :shipit:

@illusaen illusaen merged commit 5ac9963 into develop Feb 1, 2021
@illusaen illusaen deleted the fix-contact-info-inner-blocks branch February 1, 2021 22:12
@@ -1,6 +1,6 @@
[submodule "gutenberg"]
path = gutenberg
url = ../../WordPress/gutenberg.git
url = ../../illusaen/gutenberg.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @illusaen I think it would be better to keep this file pointing to WordPress folder as it was previously because it should be generic, what do you think about changing it?

Thanks!

@fluiddot
Copy link
Contributor

👋 I'm moving this to 1.46.1 milestone because it's going to be included in the beta fix.

Long story short, a PR was merged into the WordPress Android app after the 1.46.0 release was cut and due to the gutenberg-mobile submodule update these changes were included too.

Let me know if there's any concern about including in the beta fix, thanks!

@fluiddot fluiddot added this to the 1.46.1 (16.7) milestone Feb 15, 2021
@fluiddot fluiddot mentioned this pull request Feb 15, 2021
3 tasks
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants