Mobile Release v1.47.0 #29037
Merged
Mobile Release v1.47.0 #29037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
added
the
Mobile App - i.e. Android or iOS
dcalhoun
reviewed
Feb 16, 2021
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
3 tasks
* Ignore empty width attribute in columns
The editor was crashing when attempting to render a column block which contained an empty width attribute (i.e `<!-- wp:column {"width":""} -->`.
The exception occurred when accessing a property of an undefined object, so adding a default object (`|| {}`) fixes this by allowing the property to be accessed.
* Update react-native-editor changelog
* Add missing dependency to useSelect in columns block
Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
dcalhoun
reviewed
Feb 16, 2021
* Release script: Update react-native-editor version to 1.46.1 * Release script: Update with changes from 'npm run core preios' * Update react-native-editor CHANGELOG * [RNMobile] Add capability to bridge to show/hide audio block (#28952) * [RNMobile] Ignore column width attribute when empty (#29015) * Update react-native-editor CHANGELOG * Fixes minor changelog alignement issue * Add Stories bridge methods for iOS (#29083) Add missing bridge methods for the Stories block. The absence of these threw an error, even though Stories block isn't fully supported for iOS just yet. Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> Co-authored-by: David Calhoun <dpcalhoun@gmail.com>
|
At this stage this LGTM 🎉 |
dcalhoun
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
LGTM. However, before we merge, we need to...
- Determine our strategy to fix/validate the current CI checks on this PR stuck in a pending state.
- Complete the remaining release checklist tasks to merge the
1.47.0release into WPiOS and WPAndroid first.
After this, we can resolve conflicts here and merge this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.47.0 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3155
Checklist: