HTML API: Make reset insertion mode method private #7194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was intended to be an internal function. It implements an algorithm for HTML tree construction. It is not intended to be part of the public interface and has not been exposed in a release.
The algorithm is described and referred to in the specification as "reset the insertion mode appropriately." Use a name that accurately reflects the specification.
sirreal
force-pushed
the
html-api/non-public-reset-insertion-mode
branch
from
8a5fc5d to
4a13856
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
approved these changes
Aug 14, 2024
pento
pushed a commit
that referenced
this pull request
Aug 14, 2024
The algorithm is described and referred to in the specification as "reset the insertion mode appropriately." This patch renames it to more accurately reflect the specification, and it turns the public method private. As an internal algorithm from the HTML specification it should not be open to extension. Developed in #7194 Discussed in https://core.trac.wordpress.org/ticket/61549 Follow-up to [28656]. Props jonsurrell. See #61549. git-svn-id: https://develop.svn.wordpress.org/trunk@58898 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 14, 2024
The algorithm is described and referred to in the specification as "reset the insertion mode appropriately." This patch renames it to more accurately reflect the specification, and it turns the public method private. As an internal algorithm from the HTML specification it should not be open to extension. Developed in WordPress/wordpress-develop#7194 Discussed in https://core.trac.wordpress.org/ticket/61549 Follow-up to [28656]. Props jonsurrell. See #61549. Built from https://develop.svn.wordpress.org/trunk@58898 git-svn-id: http://core.svn.wordpress.org/trunk@58294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Aug 14, 2024
The algorithm is described and referred to in the specification as "reset the insertion mode appropriately." This patch renames it to more accurately reflect the specification, and it turns the public method private. As an internal algorithm from the HTML specification it should not be open to extension. Developed in WordPress/wordpress-develop#7194 Discussed in https://core.trac.wordpress.org/ticket/61549 Follow-up to [28656]. Props jonsurrell. See #61549. Built from https://develop.svn.wordpress.org/trunk@58898 git-svn-id: https://core.svn.wordpress.org/trunk@58294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
aslamdoctor
pushed a commit
to aslamdoctor/wordpress-develop
that referenced
this pull request
Dec 28, 2024
The algorithm is described and referred to in the specification as "reset the insertion mode appropriately." This patch renames it to more accurately reflect the specification, and it turns the public method private. As an internal algorithm from the HTML specification it should not be open to extension. Developed in WordPress#7194 Discussed in https://core.trac.wordpress.org/ticket/61549 Follow-up to [28656]. Props jonsurrell. See #61549. git-svn-id: https://develop.svn.wordpress.org/trunk@58898 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset_insertion_modetoreset_insertion_mode_appropriatelyto align with how it is referenced in the specification.This method was introduced in the current release cycle (for WordPress 6.7) so it has never been part of the public interface in a release and changing its visibility is not a breaking change.
The
reset_insertion_modemethod was introduced in [58656]. The method's visibility was set topublic, but it was never intended to be part of the public interface.Trac ticket: https://core.trac.wordpress.org/ticket/61549
Follow-up to https://core.trac.wordpress.org/ticket/61549
Follow-up to [58656]
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.