New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Add Progress Bar Entry #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, especially with the live demonstration!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this one change and it looks good to me, sorry I missed it last review.
Then can you squash the commits into one?
Add a bunch of safe guards to avoid hitting the expensive crasher process. Disable the crasher process by default and put it behind a "Safe Mode" setting. Move the Run Button to the headerbar Add a "Auto-Update" setting for the preview
Importan to catch issues with objects in properties. For example: DropDown { factory: ListItemFactory { Box {} }; }
James made it 3x times faster on large files See workbenchdev#240 (comment)
Added Progress Bar Entry under User Interface Section in Library
Issue workbenchdev/demos#3