Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Add Progress Bar Entry #222

Merged
merged 19 commits into from Mar 21, 2023
Merged

Conversation

SoNiC-HeRE
Copy link
Contributor

Added Progress Bar Entry under User Interface Section in Library
Issue workbenchdev/demos#3

Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, especially with the live demonstration!

src/Library/demos/Progress Bar/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Progress Bar/main.blp Show resolved Hide resolved
src/Library/demos/Progress Bar/main.js Show resolved Hide resolved
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one change and it looks good to me, sorry I missed it last review.

Then can you squash the commits into one?

src/Library/demos/Progress Bar/main.blp Outdated Show resolved Hide resolved
@sonnyp sonnyp merged commit bc7568d into workbenchdev:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants