Library: Add Adw.MessageDialog example #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
requested changes
Mar 8, 2023
Contributor
There was a problem hiding this comment.
Great start!
I was planning on waiting for Blueprint support but I guess it makes sense to create them from code anyway.
Following the GNOME HIG, I think we should have at least these 3 examples:
- Confirmation dialog
- Error dialog
- Action dialog (not required now - we can do later)
And your password example is good too - maybe under "Advanced error dialog"
sonnyp
reviewed
Mar 8, 2023
Co-authored-by: Sonny Piers <sonny@fastmail.net>
Co-authored-by: Sonny Piers <sonny@fastmail.net>
spaces Co-authored-by: Sonny Piers <sonny@fastmail.net>
Co-authored-by: Sonny Piers <sonny@fastmail.net>
replace methods with their equivalent property during construction
We now have a confirmation, error, and advanced error dialog.
updates the vala code to work with the newly updated main.blp
Contributor
|
ha - an other thing - please create a new branch before submitting a PR - don't use otherwise I have to push to your |
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Mar 13, 2023
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Mar 21, 2023
andyholmes
pushed a commit
to andyholmes/Workbench
that referenced
this pull request
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My First PR for this project! I included a .js and .vala file.
If there is any issues or recommendations please let me know!