Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing to new theme and new structure #32

Merged
merged 62 commits into from
Mar 21, 2022

Conversation

bedroesb
Copy link
Member

@bedroesb bedroesb commented Mar 3, 2022

Since the theme is being previewed from my fork I thought it would be easy to work on it immediately. Normally you should have access to it with this PR.

LIVE PREVIEW HERE

  • Restructuring the main landing page
  • Making a landing page for the documentation, or do we take Johan his page ? I now placed his content in "start guide"
  • Maybe we want "quick start guide" and "full guide" from Johan in de side menu
  • Prune the old pages, maybe get rid of them
  • Move events to new system
  • Adding the correct redirects
  • Making sure all urls work
  • Getting rid of the collapsible peices and other html snippets that are not needed anymore

@bedroesb bedroesb requested review from stain, stuzart and fbacall and removed request for stain, stuzart and fbacall March 3, 2022 14:43
CNAME Outdated Show resolved Hide resolved
@@ -2,9 +2,7 @@
title: RO-Crate Submission API
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add redirect_from for all moved pages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was volunteered to add those.. will have a go now that I can edit through this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we could not just change the URLs in workflow hub, since this will be a lot of work. Could we check on google how many of these deep links exist on google?

index.md Outdated Show resolved Hide resolved
title: Citation
---

{% include citation.md %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for using an include instead of just using its contents? This way it can be reused off course.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included in two places: the front page and its own page.

I made a separate page for it for direct linking (from the footer) because when I tried linking to the anchor (e.g. /#citation) the page didn't scroll to the correct place, possibly because some elements on the front page are loaded dynamically after the initial page load.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I missed the second use of the include. ok! https://bedroesb.github.io/about#citation this works for me though (without the backslash)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it scrolls here:
image
unless I'm already on the page when visiting the anchor

@fbacall fbacall merged commit e56e040 into workflowhub-eu:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants