-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing to new theme and new structure #32
Conversation
@@ -2,9 +2,7 @@ | |||
title: RO-Crate Submission API | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add redirect_from
for all moved pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was volunteered to add those.. will have a go now that I can edit through this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we could not just change the URLs in workflow hub, since this will be a lot of work. Could we check on google how many of these deep links exist on google?
title: Citation | ||
--- | ||
|
||
{% include citation.md %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for using an include instead of just using its contents? This way it can be reused off course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's included in two places: the front page and its own page.
I made a separate page for it for direct linking (from the footer) because when I tried linking to the anchor (e.g. /#citation
) the page didn't scroll to the correct place, possibly because some elements on the front page are loaded dynamically after the initial page load.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I missed the second use of the include. ok! https://bedroesb.github.io/about#citation this works for me though (without the backslash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the theme is being previewed from my fork I thought it would be easy to work on it immediately. Normally you should have access to it with this PR.
LIVE PREVIEW HERE