Skip to content

1904 fix datareset #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

1904 fix datareset #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d5f261
1904: Fixes circular dependency
Jun 3, 2025
1101ac0
1904: Adds changeset
Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/.changeset/weak-badgers-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'pydantic-forms': patch
---

Fixes data reset bug
44 changes: 20 additions & 24 deletions frontend/packages/pydantic-forms/src/core/PydanticFormContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import React, {
createContext,
useCallback,
useEffect,
useMemo,
useRef,
useState,
} from 'react';
Expand Down Expand Up @@ -174,17 +173,13 @@ function PydanticFormContextProvider({
componentMatcher,
);

const initialData = useMemo(
() =>
getFormValuesFromFieldOrLabels(
pydanticFormSchema,
{
...formLabels?.data,
...customData,
},
componentMatcher,
),
[componentMatcher, customData, formLabels?.data, pydanticFormSchema],
const initialData = getFormValuesFromFieldOrLabels(
pydanticFormSchema,
{
...formLabels?.data,
...customData,
},
componentMatcher,
);

// initialize the react-hook-form
Expand All @@ -204,6 +199,14 @@ function PydanticFormContextProvider({
return () => sub.unsubscribe();
}, [rhf, onChange]);

const resetFormData = useCallback(() => {
if (!pydanticFormSchema) {
return;
}

rhf.reset();
}, [pydanticFormSchema, rhf]);

rhfRef.current = rhf;

/* TODO: Reimplement
Expand Down Expand Up @@ -236,12 +239,12 @@ function PydanticFormContextProvider({
}

setFormInputHistory(new Map<string, object>());
rhf.reset(initialData);
resetFormData();
}, [
apiResponse,
initialData,
isFullFilled,
onSuccess,
resetFormData,
rhf,
skipSuccessNotice,
]);
Expand All @@ -257,6 +260,7 @@ function PydanticFormContextProvider({

// when we receive a form from the JSON, we fully reset the scheme
if (apiResponse?.form) {
resetFormData();
setRawSchema(apiResponse.form);
if (apiResponse.meta) {
setHasNext(!!apiResponse.meta.hasNext);
Expand All @@ -270,23 +274,15 @@ function PydanticFormContextProvider({
}

setIsSending(false);
}, [apiResponse, onSuccess, rhf, skipSuccessNotice]);

const resetFormData = useCallback(() => {
if (!pydanticFormSchema) {
return;
}

rhf.reset(undefined, { keepDefaultValues: true });
}, [pydanticFormSchema, rhf]);
}, [apiResponse, onSuccess, resetFormData, rhf, skipSuccessNotice]);

// a useeffect for filling data whenever formdefinition or labels update
useEffect(() => {
getHashForArray(formInputData).then((hash) => {
const currentStepFromHistory = formInputHistory.get(hash);

if (currentStepFromHistory) {
rhf.reset();
resetFormData();
Object.entries(currentStepFromHistory).forEach(
([fieldName, fieldValue]) =>
rhf.setValue(fieldName, fieldValue, {
Expand Down