Update wflow-05-faq.Rmd #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited FAQ to include workflowr/Beaker Browser method for direct sharing of entire site(s) using dat:// links.
Closed
|
@johnsonlab Thank you very much for the PR! My only two concerns are
Here's my proposal:
Since this is your first PR on GitHub, I figured this would be easier than having you update your PR by adding additional commits to the branch of your fork. Does this work for you? |
|
I accept your proposal and appreciate your understanding given this is my first pull request. Please edit accordingly and I will match the tone and limit verbosity next time. Thanks! |
|
Great. Congrats on getting your first GitHub PR merged! I'm honored it was for one of my projects! |
|
Thanks John - totally my pleasure and thanks for talking me through the
pull request process. It won't be my last!
…On Thu, Sep 7, 2017, 6:29 PM John Blischak ***@***.***> wrote:
Great. Congrats on getting your first GitHub PR merged! I'm honored it was
for one of my projects!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB17vqn_Ah6pd2HedImLOPEtojG8kjDbks5sgAvggaJpZM4PJolU>
.
|
|
@johnsonlab Thanks again for your contribution! Your FAQ is now live online: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited FAQ to include workflowr/Beaker Browser method for direct sharing of entire site(s) using dat:// links.