fix(calendar-grid): track by x-axis and migrate to the built-in control flow #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deku-nattsu
force-pushed
the
calendar-grid-trackby
branch
from
afd559a to
dbb9f00
Compare
Deku-nattsu
changed the title
Deku-nattsu
force-pushed
the
calendar-grid-trackby
branch
from
dbb9f00 to
a5ffff3
Compare
walkerkay
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters order was flipped (index should first and item second),
this change fixes the orderthis change tracks using the x-axis since it is the most unique thing in date points array, this also migrates to the new control flow