Add `--all` flag to remove all terms from a post

[BhargavBhandari90]

Add parameter to remove all terms from the particular post

Fixes #18

[schlessera]

Please add relevant functional tests for this. See https://make.wordpress.org/cli/handbook/pull-requests/#running-and-writing-tests

[schlessera]

Please add relevant functional tests for this. See https://make.wordpress.org/cli/handbook/pull-requests/#running-and-writing-tests

[BhargavBhandari90]

Please add relevant functional tests for this

I tried running behat test.
When I tried to run ./vendor/bin/behat --expand, then I am getting below error

[RuntimeException]
$ mkdir -p "C:\Users\bunty\AppData\Local\Temp/wp-cli-test-cache"
A subdirectory or file -p already exists.
Error occurred while processing: -p.
A subdirectory or file C:\Users\bunty\AppData\Local\Temp/wp-cli-test-cache already exists.
Error occurred while processing: C:\Users\bunty\AppData\Local\Temp/wp-cli-test-cache.
cwd:
exit status: 1

Am I doing something wrong?

[BhargavBhandari90]

Please add relevant functional tests for this

I tried running behat test.
When I tried to run ./vendor/bin/behat --expand, then I am getting below error

[RuntimeException]
$ mkdir -p "C:\Users\bunty\AppData\Local\Temp/wp-cli-test-cache"
A subdirectory or file -p already exists.
Error occurred while processing: -p.
A subdirectory or file C:\Users\bunty\AppData\Local\Temp/wp-cli-test-cache already exists.
Error occurred while processing: C:\Users\bunty\AppData\Local\Temp/wp-cli-test-cache.
cwd:
exit status: 1

Am I doing something wrong?

[BhargavBhandari90]

@schlessera All changes reported by you are done. Please review it.

[BhargavBhandari90]

@schlessera All changes reported by you are done. Please review it.

[schlessera]

This is not quite what I meant.

The general principle is that you want to reduce both indentation levels and the number of else branches that you have in your code. This helps reduce overally complexity, because your code ends up having less branches going on at the same time.

To achieve this, one popular and useful method is to bail early where it makes sense.

This can be done here by turning the code around.

So, instead of this:

} else {
   if ( $terms ) {
      $result = ...
   } else {
      WP_CLI::error( ... );
   }
}

we want to prefer this:

} else {
   if ( ! $terms ) {
      WP_CLI::error( ... );
   }
   $result = ...
}

This reduces the indentation level of the $result = ... statement, because we completed one possible branch above by exiting the code early if our condition is not met.

[danielbachhuber]

Can you add functional tests please? Here's an introduction: https://make.wordpress.org/cli/handbook/pull-requests/

[BhargavBhandari90]

@schlessera @danielbachhuber I have added the functional test for the feature. Please check this.

[BhargavBhandari90]

@schlessera @danielbachhuber I have added the functional test for the feature. Please check this.

[BhargavBhandari90]

@schlessera @danielbachhuber All changes are done. Please confirm this.

[BhargavBhandari90]

@schlessera @danielbachhuber All changes are done. Please confirm this.

[danielbachhuber]

@BhargavBhandari90 Thanks for your work on this!

[danielbachhuber]

@BhargavBhandari90 Thanks for your work on this!