Add strict/no-strict mode for taxonomy list #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would strict mean here? What issue does it solve? |
|
@swissspidy I am working on this issue: #181 |
swissspidy
changed the title
schlessera
requested changes
May 7, 2019
|
Great, code looks good. Can you add one or more functional tests to make sure it also works as expected? |
|
@schlessera . I'll be adding the functional tests over the weekend. Thanks 👍 |
|
@schlessera for this, does it need a check here in FeatureContext ? |
|
Oh, thanks @thrijith, somehow I had looked at the wrong test output here... 🙃 |
|
@schlessera Somehow the test is failing. I am not sure about that. May be it's related to what @thrijith was saying...? |
|
Does the new flag not need to be documented in the function header? |
|
@grappler Yes, indeed! That will be for the next release then, as I just pushed 2.6.0. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
strictmode for taxonomy list command.Default will be --no-strict
Fixes #181.