Skip to content

Fix PHP notice in comment recount with invalid ID #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Fix PHP notice in comment recount with invalid ID #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9be7d88
Fix comment recount output
ernilambar Feb 14, 2024
e380ef2
Add behat test for invalid id for comment recount
ernilambar Feb 14, 2024
0ddfaaa
Fix condition for comment count check
ernilambar Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions features/comment-recount.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,9 @@ Feature: Recount comments on a post
"""
Updated post 1 comment count to 3.
"""

When I try `wp comment recount 99999999`
Then STDERR should be:
"""
Warning: Post 99999999 doesn't exist.
"""
7 changes: 3 additions & 4 deletions src/Comment_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,12 +672,11 @@ public function count( $args, $assoc_args ) {
*/
public function recount( $args ) {
foreach ( $args as $id ) {
wp_update_comment_count( $id );
$post = get_post( $id );
if ( $post ) {
if ( wp_update_comment_count( $id ) ) {
$post = get_post( $id );
WP_CLI::log( "Updated post {$post->ID} comment count to {$post->comment_count}." );
} else {
WP_CLI::warning( "Post {$post->ID} doesn't exist." );
WP_CLI::warning( "Post {$id} doesn't exist." );
}
}
}
Expand Down