Skip to content

Fix warning message in user spam command #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix warning message in user spam command #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion features/user.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,6 @@ Feature: Manage WordPress users
And STDERR should be:
"""
Warning: Invalid user ID, email or login: '9999'
Warning: User 9999 doesn't exist.
Error: Only spammed 1 of 2 users.
"""
And the return code should be 1
Expand Down
11 changes: 2 additions & 9 deletions src/User_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,15 +1339,8 @@ private function update_msuser_status( $user_ids, $pref, $value ) {
$errors = count( $user_ids ) - count( $users );
}

foreach ( $user_ids as $user_id ) {

$user = get_userdata( $user_id );

// If no user found, then show warning.
if ( empty( $user ) ) {
WP_CLI::warning( "User {$user_id} doesn't exist." );
continue;
}
foreach ( $users as $user ) {
$user_id = $user->ID;

// Super admin should not be marked as spam.
if ( is_super_admin( $user->ID ) ) {
Expand Down