Skip to content

wp option - new autoload values in autoload filter #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 18, 2025
Merged

wp option - new autoload values in autoload filter #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba3e5cc
Fix: change the old option values to newer values
imrraaj Oct 22, 2024
61eb500
fix: also search for old values
imrraaj Oct 23, 2024
a5e51e0
Add test case scenarios for --autoload flag
imrraaj Nov 4, 2024
1882e62
Add test case scenarios for --autoload flag
imrraaj Nov 4, 2024
c47bdaa
Uncomment commented code
imrraaj Nov 4, 2024
f607f76
Fix the testcases for the --autolaod flag in option list command
imrraaj Nov 5, 2024
3c71535
Merge branch 'main' into fix/autoload-options
swissspidy Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions features/option-list.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,3 +148,53 @@ Feature: List WordPress options
option_value:
value: 1
"""

Scenario: Using the `--autoload=on` flag
Given a WP install
And I run `wp option add sample_autoload_one 'sample_value_one' --autoload=yes`
And I run `wp option add sample_autoload_two 'sample_value_two' --autoload=no`
And I run `wp option add sample_autoload_three 'sample_value_three' --autoload=on`
And I run `wp option add sample_autoload_four 'sample_value_four' --autoload=off`

When I run `wp option list --autoload=on`
Then STDOUT should not contain:
"""
sample_value_two
"""
And STDOUT should not contain:
"""
sample_value_four
"""
And STDOUT should contain:
"""
sample_value_one
"""
And STDOUT should contain:
"""
sample_value_three
"""

Scenario: Using the `--autoload=off` flag
Given a WP install
And I run `wp option add sample_autoload_one 'sample_value_one' --autoload=yes`
And I run `wp option add sample_autoload_two 'sample_value_two' --autoload=no`
And I run `wp option add sample_autoload_three 'sample_value_three' --autoload=on`
And I run `wp option add sample_autoload_four 'sample_value_four' --autoload=off`

When I run `wp option list --autoload=off`
Then STDOUT should not contain:
"""
sample_value_one
"""
And STDOUT should not contain:
"""
sample_value_three
"""
And STDOUT should contain:
"""
sample_value_two
"""
And STDOUT should contain:
"""
sample_value_four
"""
4 changes: 2 additions & 2 deletions src/Option_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,9 @@ public function list_( $args, $assoc_args ) {
if ( isset( $assoc_args['autoload'] ) ) {
$autoload = $assoc_args['autoload'];
if ( 'on' === $autoload || 'yes' === $autoload ) {
$autoload_query = " AND autoload='yes'";
$autoload_query = " AND (autoload='on') OR (autoload='yes')";
} elseif ( 'off' === $autoload || 'no' === $autoload ) {
$autoload_query = " AND autoload='no'";
$autoload_query = " AND (autoload='off') OR (autoload='no')";
} else {
WP_CLI::error( "Value of '--autoload' should be 'on', 'off', 'yes', or 'no'." );
}
Expand Down