Skip to content

Fix fatal error issue in in_array function #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025
Merged

Fix fatal error issue in in_array function #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31a6294
Fix fatal error issue in in_array function
itsmekopila Mar 18, 2025
0293407
Update condition to check only is_array
Mar 19, 2025
4e156bc
Merge branch 'main' into fix/429
swissspidy May 6, 2025
71406b9
Add test
swissspidy May 6, 2025
f9f516a
Fix gherkin lint
swissspidy May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions features/plugin-auto-updates-status.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,10 @@ Feature: Show the status of auto-updates for WordPress plugins
hello,disabled
duplicate-post,disabled
"""

@require-wp-5.5
Scenario: Handle malformed option value
When I run `wp option update auto_update_plugins ""`
And I try `wp plugin auto-updates status hello`
Then the return code should be 0
And STDERR should be empty
6 changes: 3 additions & 3 deletions src/Plugin_AutoUpdates_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function enable( $args, $assoc_args ) {
$plugins = $this->fetcher->get_many( $args );
$auto_updates = get_site_option( static::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down Expand Up @@ -162,7 +162,7 @@ public function disable( $args, $assoc_args ) {
$plugins = $this->fetcher->get_many( $args );
$auto_updates = get_site_option( static::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down Expand Up @@ -278,7 +278,7 @@ public function status( $args, $assoc_args ) {
$plugins = $this->fetcher->get_many( $args );
$auto_updates = get_site_option( static::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down
2 changes: 1 addition & 1 deletion src/Plugin_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ protected function get_item_list() {

$auto_updates = get_site_option( Plugin_AutoUpdates_Command::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down
6 changes: 3 additions & 3 deletions src/Theme_AutoUpdates_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function enable( $args, $assoc_args ) {
$themes = $this->fetcher->get_many( $args );
$auto_updates = get_site_option( static::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down Expand Up @@ -162,7 +162,7 @@ public function disable( $args, $assoc_args ) {
$themes = $this->fetcher->get_many( $args );
$auto_updates = get_site_option( static::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down Expand Up @@ -278,7 +278,7 @@ public function status( $args, $assoc_args ) {
$themes = $this->fetcher->get_many( $args );
$auto_updates = get_site_option( static::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down
2 changes: 1 addition & 1 deletion src/WP_CLI/ParseThemeNameInput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ private function get_all_themes() {

$auto_updates = get_site_option( Theme_AutoUpdates_Command::SITE_OPTION );

if ( false === $auto_updates ) {
if ( ! is_array( $auto_updates ) ) {
$auto_updates = [];
}

Expand Down