Skip to content

Allow filtering languages by multiple statuses #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Allow filtering languages by multiple statuses #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5fa090
#96 Make it possible to filter on multiple values
michaelw85 Jan 7, 2025
cd74883
Write test listing languages by multiple statusses
michaelw85 Jan 7, 2025
b15b0bc
Add support for multiple statuses to other commands + write tests
michaelw85 Jan 7, 2025
dd7e481
Add force to theme install to make sure it exists in all php versions
michaelw85 Jan 7, 2025
007f77d
Update test, move when into prep of the scenario using and
michaelw85 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions features/language-core.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,3 +535,16 @@ Feature: Manage translation files for a WordPress install
"""
en_US
"""

@require-wp-4.0
Scenario: List languages by multiple statuses
Given a WP install
And an empty cache
And I run `wp language core install nl_NL`

When I run `wp language core list --fields=language,status --status=active,installed`
Then STDOUT should be a table containing rows:
| language | status |
| en_US | active |
| nl_NL | installed |
And STDERR should be empty
13 changes: 13 additions & 0 deletions features/language-plugin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,3 +439,16 @@ Feature: Manage translation files for a WordPress install
jetpack,invalid_lang,"not available"
"""
And STDERR should be empty

@require-wp-4.0
Scenario: List languages by multiple statuses
Given a WP install
And an empty cache
And I run `wp language plugin install akismet nl_NL`

When I run `wp language plugin list --all --fields=plugin,language,status --status=active,installed`
Then STDOUT should be a table containing rows:
| plugin | language | status |
| akismet | en_US | active |
| akismet | nl_NL | installed |
And STDERR should be empty
14 changes: 14 additions & 0 deletions features/language-theme.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,3 +314,17 @@ Feature: Manage translation files for a WordPress install
twentysixteen,de_DE,"not installed"
"""
And STDERR should be empty

@require-wp-4.0
Scenario: List languages by multiple statuses
Given a WP install
And an empty cache
And I run `wp theme install twentyten --force`
And I run `wp language theme install twentyten nl_NL`

When I run `wp language theme list twentyten --fields=language,status --status=active,installed`
Then STDOUT should be a table containing rows:
| language | status |
| en_US | active |
| nl_NL | installed |
And STDERR should be empty
2 changes: 1 addition & 1 deletion src/Core_Language_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function ( $translation ) use ( $available, $current_locale, $updates ) {

foreach ( $translations as $key => $translation ) {
foreach ( array_keys( $translation ) as $field ) {
if ( isset( $assoc_args[ $field ] ) && $assoc_args[ $field ] !== $translation[ $field ] ) {
if ( isset( $assoc_args[ $field ] ) && ! in_array( $translation[ $field ], array_map( 'trim', explode( ',', $assoc_args[ $field ] ) ), true ) ) {
unset( $translations[ $key ] );
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Plugin_Language_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function list_( $args, $assoc_args ) {

// Support features like --status=active.
foreach ( array_keys( $translation ) as $field ) {
if ( isset( $assoc_args[ $field ] ) && $assoc_args[ $field ] !== $translation[ $field ] ) {
if ( isset( $assoc_args[ $field ] ) && ! in_array( $translation[ $field ], array_map( 'trim', explode( ',', $assoc_args[ $field ] ) ), true ) ) {
continue 2;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Theme_Language_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function ( $file ) {

// Support features like --status=active.
foreach ( array_keys( $translation ) as $field ) {
if ( isset( $assoc_args[ $field ] ) && $assoc_args[ $field ] !== $translation[ $field ] ) {
if ( isset( $assoc_args[ $field ] ) && ! in_array( $translation[ $field ], array_map( 'trim', explode( ',', $assoc_args[ $field ] ) ), true ) ) {
continue 2;
}
}
Expand Down
Loading