Light updates to the install-wp-tests.sh script
#356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
GaryJones
reviewed
Oct 6, 2025
| if [[ $1 =~ ^(y|yes)$ ]] | ||
| then | ||
| mysqladmin drop $DB_NAME -f --user="$DB_USER" --password="$DB_PASS"$EXTRA | ||
| if [ `which mariadb-admin` ]; then |
There was a problem hiding this comment.
Just because MariaDB might exist locally, is that sufficient to know that the developer wants to use it?
There was a problem hiding this comment.
We could allow overriding with a flag perhaps if needed.
|
Nice update! Moving to GIT that is better supported. |
GaryJones
reviewed
Oct 7, 2025
Co-authored-by: Gary Jones <gamajo@gamajo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on changes in some of my own project.
Related:
install-wp-tests.shscript #322