orderNotes returns null

[flocosnier]

When querying customer orders, I'm trying to get the order notes but the query returns an empty array.

Here's the query :

query getCustomer($id: ID!) {
		customer(id: $id) {
			username
			calculatedShipping
			databaseId
			date
			displayName
			email
			firstName
			hasCalculatedShipping
			id
			isJwtAuthSecretRevoked
			isPayingCustomer
			isVatExempt
			jwtAuthExpiration
			jwtAuthToken
			jwtRefreshToken
			jwtUserSecret
			lastName
			shipping {
				address1
				address2
				city
				company
				country
				email
				firstName
				lastName
				phone
				postcode
				state
			}
			billing {
				address1
				address2
				city
				company
				country
				email
				firstName
				lastName
				phone
				postcode
				state
			}
			orderCount
			orders {
				edges {
					node {
						orderNotes {
							edges {
								isCustomerNote
								node {
									content
									date
								}
							}
						}
						billing {
							address1
							address2
							city
							company
							email
							country
							lastName
							firstName
							state
							postcode
							phone
						}
						shipping {
							address1
							address2
							city
							company
							email
							country
							lastName
							firstName
							state
							postcode
							phone
						}
						cartHash
						cartTax
						commentCount
						commentStatus
						createdVia

						customerNote
						datePaid
						dateCompleted
						date
						databaseId
						discountTax(format: FORMATTED)
						discountTotal(format: FORMATTED)
						hasBillingAddress
						hasDownloadableItem
						hasShippingAddress
						id
						isDownloadPermitted
						metaData {
							id
							key
							value
						}
						modified
						needsPayment
						needsProcessing
						needsShippingAddress
						orderKey
						orderNumber
						orderVersion
						paymentMethod
						paymentMethodTitle
						pricesIncludeTax
						transactionId
						totalTax(format: FORMATTED)
						total(format: FORMATTED)
						subtotal
						status
						shippingTotal
						shippingTax
						shippingAddressMapUrl
						lineItems {
							edges {
								node {
									subtotal
									product {
										id
										databaseId
										slug
										name
										attributes {
											edges {
												node {
													name
												}
											}
										}
										... on SimpleProduct {
											price(format: FORMATTED)
										}
										... on VariableProduct {
											price(format: FORMATTED)
										}

										image {
											mediaItemUrl
											altText
										}
									}
									variation {
										description
									}
									quantity
								}
							}
						}
					}
				}
			}
		}
	}

[kidunot89]

@flocosnier Check customerNote 🤔. orderNotes might need permissions due to some of them being not meant for the end-user to see.

[robbiebel]

I confirm that issue orderNotes are returning empty, even in admin account.

[robbiebel]

A workaround who need to use orderNotes:

// Show order notes to admin and order author
add_filter( 'graphql_data_is_private', function ($is_private, $model_name, $data, $visibility, $owner, $current_user) {
    if ($model_name == 'CommentObject' && $data->comment_type == 'order_note') {
        // Check if user can edit shop orders
        if (current_user_can('edit_shop_orders', $data->comment_post_ID)) {
            return false;
        }
        
        // Check if current user is the order owner
        $order = wc_get_order($data->comment_post_ID);
        if ($order && $order->get_user_id() === $current_user->ID) {
            return false;
        }
    }

    return $is_private;
}, 10, 6);

I think it should be written a new OrderNote model which extends from WpGraphQL's Model/Comment class to override model's is_private function to compare if the current user is the owner of the order. We also need to extend CommentLoader and CommentResolver.

Or we will just register orderNotes as a new field and resolve with Woocommerce's built in function.

@kidunot89 which one is correct, or any other trick to handle this easily?