Skip to content

Conversation

kidunot89
Copy link
Collaborator

@kidunot89 kidunot89 commented Jun 5, 2019

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Some cleanup. Adds more tests and removes some unnecessary types.

Progress checklist

Connection Tests
  • Product to Term
  • Term to Product
  • Product to MediaItem
Modelless WPObjectType Test
Types Removed
  • ProductRatingCount
Code coverage increased
  • Product
  • ProductVariation

Does this close any currently open issues?

#46

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 18.04

WordPress Version: 5.2

@kidunot89 kidunot89 added enhancement New feature or request work in progress Solution development in progress labels Jun 5, 2019
@kidunot89 kidunot89 self-assigned this Jun 5, 2019
@kidunot89 kidunot89 merged commit 6baf963 into wp-graphql:release-v0.1.1 Jun 6, 2019
@kidunot89 kidunot89 changed the title ProductToTerm connection and TermToProduct connections tests added. Cleanup/Code coverage update. Jun 6, 2019
@kidunot89 kidunot89 removed the work in progress Solution development in progress label Jun 6, 2019
@kidunot89 kidunot89 deleted the feature/more-tests branch September 7, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant