Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCP & ATF: refactor global clearing, banners for SaaS features #6319

Closed
remyperona opened this issue Dec 11, 2023 · 0 comments · Fixed by #6328
Closed

LCP & ATF: refactor global clearing, banners for SaaS features #6319

remyperona opened this issue Dec 11, 2023 · 0 comments · Fixed by #6328
Assignees
@remyperona
Labels
effort: [S] 1-2 days of estimated development time type: sub-task Indicates the issue is a sub-task linked to an epics card
Milestone
3.16

Comments

@remyperona
Copy link
Contributor

Scope a solution ✅

Refactor to a new common SaaS class:

  • the global and URL used CSS & LCP/ATF clearing
  • Manage the wording of the clearing buttons depending on which features are enabled
  • the banners displayed for counter, license expired, API not reachable
  • Disable the features when license is expired

Estimate the effort ✅

Effort [S]
@remyperona remyperona added the type: sub-task Indicates the issue is a sub-task linked to an epics card label Dec 11, 2023
@remyperona remyperona added this to the 3.16 milestone Dec 11, 2023
@remyperona remyperona self-assigned this Dec 12, 2023
@remyperona remyperona mentioned this issue Dec 12, 2023
Merged
5 tasks
@remyperona remyperona added the effort: [S] 1-2 days of estimated development time label Dec 15, 2023
remyperona added a commit that referenced this issue Dec 15, 2023
@remyperona
Closes #6319 Create SaaS global clear and banners (#6328)
0b20b40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remyperona remyperona

Labels
effort: [S] 1-2 days of estimated development time type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Milestone
3.16
Development

Successfully merging a pull request may close this issue.

Closes #6319 Create SaaS global clear and banners wp-media/wp-rocket
1 participant
@remyperona