Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6319 Create SaaS global clear and banners #6328

Conversation

remyperona
Copy link
Contributor

Description

Add new SaaS admin classes to manage global clear and banners for all SaaS features.

Fixes #6319

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).

@remyperona remyperona changed the base branch from develop to feature/lcp-above-the-fold-optimization December 12, 2023 21:42
@remyperona remyperona self-assigned this Dec 14, 2023
@remyperona remyperona requested a review from a team December 14, 2023 19:17
@remyperona remyperona added this to the 3.16 milestone Dec 14, 2023
@remyperona remyperona added lcp type: sub-task Indicates the issue is a sub-task linked to an epics card labels Dec 14, 2023
@remyperona remyperona marked this pull request as ready for review December 14, 2023 19:18
inc/Engine/Saas/Admin/Notices.php Show resolved Hide resolved
inc/Engine/Saas/Admin/Notices.php Show resolved Hide resolved
inc/Engine/Saas/Admin/Notices.php Show resolved Hide resolved
@remyperona remyperona merged commit 0b20b40 into feature/lcp-above-the-fold-optimization Dec 15, 2023
0 of 7 checks passed
@remyperona remyperona deleted the task/6319-global-clear-banners branch December 15, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCP & ATF: refactor global clearing, banners for SaaS features
3 participants