Skip to content

Fix method name #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2021
Merged

Fix method name #4

merged 4 commits into from
Apr 30, 2021

Conversation

AlexP11223
Copy link
Contributor

No description provided.

XedinUnknown
XedinUnknown requested changes Apr 7, 2021
View reviewed changes
Copy link
Member

@XedinUnknown XedinUnknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs unit tests, like here.

@XedinUnknown XedinUnknown self-assigned this Apr 7, 2021
@AlexP11223 AlexP11223 requested a review from XedinUnknown April 7, 2021 09:42
@AlexP11223
Copy link
Contributor Author

Added tests. Besides the type they also test that we can actually e.g. call parseBlocks with a string and it can return an array of blocks.

XedinUnknown
XedinUnknown requested changes Apr 7, 2021
View reviewed changes
@AlexP11223 AlexP11223 requested a review from XedinUnknown April 7, 2021 13:27
@XedinUnknown XedinUnknown merged commit 2b12f4c into wp-oop:develop Apr 30, 2021
@AlexP11223 AlexP11223 deleted the fix/name branch April 30, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XedinUnknown XedinUnknown XedinUnknown approved these changes

Assignees

@XedinUnknown XedinUnknown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexP11223 @XedinUnknown