-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display robot outline #99
base: main
Are you sure you want to change the base?
Conversation
Thanks for working on this! Right now we're focusing on getting PR #96 ready for beta which is coming up shortly. Once that's in, we should figure out how to integrate this PR as there is some overlap. |
…to show-robot # Conflicts: # src/main/java/edu/wpi/first/pathweaver/CreateProjectController.java # src/main/java/edu/wpi/first/pathweaver/PathDisplayController.java # src/main/resources/edu/wpi/first/pathweaver/createProject.fxml # src/main/resources/edu/wpi/first/pathweaver/style.css
So a recent PR added the ability to edit your project (it loads your current values into the Create Project screen essentially). Can you add the new Preferences here as well: https://github.com/wpilibsuite/PathWeaver/blob/master/src/main/java/edu/wpi/first/pathweaver/CreateProjectController.java#L115 |
Whoops, looks like I totally missed that! Fixed 😄 |
What is the status of this PR is it ready to be reviewed/merged? |
Good question -- it's been a while! Not sure how bad the conflicts are, but last I remember this was ready to go. |
Do you want to handle the conflicts or do you want/need me to take this over? |
this would be mega useful |
Description
Closes #47
This PR makes it easier to see the robot's state at any given waypoint and makes it easier for the user to estimate what field obstacles a robot may run into while traveling through its path. To do this, it adds two properties to the settings which control the robot's dimensions.
Screenshots
Create Project
User can specify robot width and height.
Path Viewer