Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change recording file extension from .frc to .sbr #179

Merged
merged 2 commits into from
Sep 7, 2017

Conversation

rrlapointe
Copy link
Contributor

Change the file extension used for recordings from .frc to .sbr

Change the name of the recording file type in the file chooser from "FRC Data Recording" to "Shuffleboard Data Recording"
@rrlapointe
Copy link
Contributor Author

This PR resolves #43

Copy link
Member

@SamCarlberg SamCarlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #179 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
- Coverage     16.07%   15.83%   -0.24%     
  Complexity      246      246              
============================================
  Files           143      143              
  Lines          3683     3738      +55     
  Branches        286      297      +11     
============================================
  Hits            592      592              
- Misses         3062     3117      +55     
  Partials         29       29

@SamCarlberg SamCarlberg merged commit 41e70dc into master Sep 7, 2017
@SamCarlberg SamCarlberg deleted the recording_file_extension branch September 7, 2017 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants