This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
Remove CTRE ifdef code for integration tests #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piphi5
force-pushed
the
remove-ctre-ifdef
branch
from
a6cda09
to
e471a92
Compare
|
Waiting on #255 to be merged |
Piphi5
force-pushed
the
remove-ctre-ifdef
branch
from
e471a92
to
4aaef28
Compare
Piphi5
force-pushed
the
remove-ctre-ifdef
branch
3 times, most recently
from
33580e8
to
3409714
Compare
|
The commit message should also mention there's changes to some function arguments to fix lifetime issues. Ideally, that would be in a separate commit. |
Piphi5
force-pushed
the
remove-ctre-ifdef
branch
from
3409714
to
5fe353b
Compare
|
You should do an interactive rebase with each commit set to "edit" so you can check each commit compiles. That should help you track down the build issue. |
Piphi5
force-pushed
the
remove-ctre-ifdef
branch
from
5fe353b
to
2e65d1e
Compare
calcmogul
suggested changes
Dec 22, 2021
Piphi5
force-pushed
the
remove-ctre-ifdef
branch
from
2e65d1e
to
fa35984
Compare
calcmogul
approved these changes
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bug caught by the integration tests