Rename #162
Merged
Rename #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizlooney
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This really does fix 2 issues that in our current code base.
However, it does not fix a nasty race condition when you rename an item in the tabs. The problem is that we store the path information in multiple places. It is in the project, but is also the "key" for each tab. These can get out of sync such that when we go to save a module that has been renamed, it is trying to save to the old name which doesn't exist anymore.
I think this will require a pretty major change to how tabs work and I am just not fresh enough to do that right now.
A long way to say: Should we merge this in now (since it does fix 2 real issues) or should we wait until I have fixed the renaming race condition?