Cleaned up mrc_port #257
Merged
Cleaned up mrc_port #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added constants for port types. - Added constants for field prefixes. - Added constants for visible port labels. - Removed type MrcPortType, ports_ from PortMixin, and ports from PortExtraState. - Renamed PortMixin portType_ to mrcPortType. - Added mrcPortCount to PortMixin. - Rewrote loadExtraState to create the appropriate fields for the portType. - Removed updateShape. - Simplified the code in pythonFromBlock that collects the ports. - Generate code for CompoundPort without trailing backslashes. - Changed Order.ATOMIC to Order.FUNCTION_CALL. - Updated createPort to specify the field values. In field_number_dropdown.ts: Removed defaultVal parameter in createFieldNumberDropdown function. In external_samples/port.py: Replace PortType enum value BASE_COMPOUND with a module variable named _base_compound. Removed PortType enum value SERVO_PORT. Added PortType enum value USB_HUB_PORT. Removed external_samples/servo.py.
alan412
requested changes
Sep 26, 2025
…face into pr_mrc_port
…face into pr_mrc_port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
Fixes #256
In mrc_port.ts.
In field_number_dropdown.ts:
Removed defaultVal parameter in createFieldNumberDropdown function.
In external_samples/port.py:
Replace PortType enum value BASE_COMPOUND with a module variable named _base_compound. Removed PortType enum value SERVO_PORT.
Added PortType enum value USB_HUB_PORT.
Removed external_samples/servo.py.