Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Refactor installation process, see #43 #47

Closed
wants to merge 2 commits into from
Closed

Refactor installation process, see #43 #47

wants to merge 2 commits into from

Conversation

franz-josef-kaiser
Copy link

Reason

To avoid having to read "Quickstart" instructions (which I did not do), here's a PR to enhance and smoothen the installation.

⚠️ It turns the Composer setup inside out and runs it from within the box and syncs it outwards.

Changes

Move initial Composer download to shell provisioning script
Move initial Composer installation to shell provisioning script
Comment shell provisiong script
Move Composer installation and update tasks to 'www' folder
Adjust composer JSON file according to new structure
Update vcs/git ignore with new structure

Affected Issues

Closes #43 #46

Move initial Composer download to shell provisioning script
Move initial Composer installation to shell provisioning script
Comment shell provisiong script
Move Composer installation and update tasks to 'www' folder
Adjust composer JSON file according to new structure
Update vcs/git ignore with new structure

Closes #43 #46
@franz-josef-kaiser
Copy link
Author

@clubdeuce sorry for filing this against master in case you have rules for PRs here in place and merge against some different branch.

@mikeschinkel
Copy link
Member

Hey @franz-josef-kaiser:

THANK YOU for the pull request.

Unfortunately @clubdeuce and I had discussed a change to be released for 0.10.6 (in a few weeks?) that will eliminate the need for composer install. I thought we had a ticket for it already but realized we did not so I just added it:

#48

Would love your feedback on that approach. But please remember our goal for this box is to be as EASY to get setup as possible. We plan another box whose goal will be to be as POWERFUL as possible.

@mikeschinkel
Copy link
Member

mikeschinkel commented May 1, 2016

Since we are planning to commit the results of Composer to this repo so this repo will be viewed more as an "Appliance" rather than a source code project, and since we are moving away from our Vagrantfile being "sacred" -- IOW we want people to manage their own Vagrantfile -- with the help of a planned Vagrant plugin, of course we are going to go ahead and close the pull request. But I really do appreciate you offering it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants