Removing the NUP utility (nup.exe) #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiwangncar
approved these changes
Sep 29, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: choose one of feature removed
KEYWORDS: nup.exe, WRFV4, Makefile
SOURCE: Internal
DESCRIPTION OF CHANGES: The NUP utility has been deprecated since version 3.7: It is not compiled unless a user manually edits the Makefile, and we do not recommend its use. This commit will fully remove the NUP code and make rules from the repository.
LIST OF MODIFIED FILES:
M Makefile
M main/Makefile
M main/depend.common
D main/nup_em.F
TESTS CONDUCTED: Ran a WTF on Cheyenne (gnu and intel) and it passed as expected; this utility has not been used or tested for some time. WTF on all this week's changes on Yellowstone also passed (gnu, intel, pgi). WTF ensures that I did not accidentally break anything else with my makefile edits.