-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/single page app #3585
Merged
Merged
Feature/single page app #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/single-page-app
benlaken
approved these changes
Sep 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally, and I can't seem to break it. 👍
If there are no issues I am going to merge :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
"Do you like big PRs? Because refactoring is how you get big PRs." - me 🥇
NOTE: to run this branch you will need to forgot everything you thought you knew about running branches [in GFW]. I highly recommend that you stop what your doing and run
yarn
. Then 🙏 . Then runyarn start
. This isn't a game.Up until now GFW has operated on a fairly bare bones webpack and development environment due to the need for creation of isolated react pages within the app. With the new map coming along nicely, we likely now want to merge this all onto a single react router AND start code splitting this react app for better performance. So I have gone and done it, or at least started it.
This first round of refactoring includes:
app
pack and router for the main applicationheader
pack for embedding the header in backbone pagesmap
pack for adding the recent imagery feature to the old map with introducing breaking changesreact-universal-component
and alsosplitChunks
to split and cache our node_modules are vendors. Quite the improvement.redux-tools
for a more efficient and consistent actions workflow.{ actions, reducers, initialsState }
asreduxModule
to assist in reducing code splitting page pack sizes.react-universal-component
to handle dynamic importing of page packs inside thelayouts/root
component.CAVEATs:
app/javascript
has been maintained for now until we merge this branch with develop. This is to make building on staging easier. Once it has been merge then we can move all components etc inside theapp
folder.NavLink
components to move between views.Demo
Too many things. Pull and start.
Testing