New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go Modules #10

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link
Contributor

SamWhited commented Dec 18, 2018

This PR is a bit more complicated too because changes need to be made for v2, but I wasn't sure if you'd want this in one place vs. the other. If this PR is accepted I'll make a separate one adding this commit to the v2 branch and updating the import path as required by the new import compatibility rule.
EDIT: I went ahead and made a patch against the v2 branch at #15

Thanks for your consideration!

@SamWhited SamWhited force-pushed the SamWhited:support_modules branch from 4761644 to d577f32 Jan 13, 2019

@@ -0,0 +1,8 @@
module github.com/writeas/go-writeas

This comment has been minimized.

@SamWhited

SamWhited Jan 13, 2019

Author Contributor

I changed the package import path to GitHub because I thought you told me you were moving everything there, but please review in case I'm wrong. Thanks.

This comment has been minimized.

@thebaer

thebaer Jan 14, 2019

Member

Yep, this is good 👍

@SamWhited SamWhited referenced this pull request Jan 13, 2019

Open

Support modules #15

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Jan 14, 2019

Thanks for submitting this. Looks good!

@thebaer thebaer merged commit ec51782 into writeas:master Jan 14, 2019

@SamWhited SamWhited deleted the SamWhited:support_modules branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment