Support Go Modules #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWhited
commented
Jan 13, 2019
| @@ -0,0 +1,8 @@ | |||
| module github.com/writeas/go-writeas | |||
There was a problem hiding this comment.
I changed the package import path to GitHub because I thought you told me you were moving everything there, but please review in case I'm wrong. Thanks.
Merged
|
Thanks for submitting this. Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit more complicated too because changes need to be made for v2, but I wasn't sure if you'd want this in one place vs. the other. If this PR is accepted I'll make a separate one adding this commit to the v2 branch and updating the import path as required by the new import compatibility rule.
EDIT: I went ahead and made a patch against the v2 branch at #15
Thanks for your consideration!