Use ModeSwitch #10
Merged
Use ModeSwitch #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with Ctrl+T and the switch not reflecting correct state when starting up -- previously, darkmode_switch was initialized in construct_toolbar() as a local variable.
|
Love it! This looks really nice. I didn't know about the Granite stuff before. Will definitely be looking through that in the future. I figured out what was causing the bug -- just an extra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. It mostly works, but I am getting an issue when restoring the dark mode: the switch is not set to active.
Note that this does not introduce a dependency on Granite; instead, the Granite ModeSwitch is pulled into the codebase. Either way could work, it is up the @writeas developers.
Will close #9 if/when merged.