Improve accessibility labels and hints #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to silence runtime warnings about missing images for the workaround used to add a11y labels/hints to toolbar buttons.
It’s impossible to differentiate these textviews because the placeholder text is not read by VoiceOver, so we need to add labels.
Adding an .onTapGesture modifier here to dismiss the keyboard removes focus from whatever textview is active in the post editor, which prevents VoiceOver from getting confused about which accessibility frame should be read.
Merged
AngeloStavrow
added
ios
thebaer
reviewed
Jan 7, 2021
thebaer
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159.
This PR adds better labels and hints to icon-only buttons for VoiceOver users. Some hacks were required to workaround a SwiftUI where accessibility modifiers are not used as expected for buttons in toolbars (see FB8956392), and comments to this effect are present in the source code committed.
I'm not sure of a way to test this without a device, so I made a recording of VoiceOver reading out some of the icon-only button labels, as well as the post editor text fields (watch with sound on 🎧):
voiceover-demo.mov