Fix dismiss post bug #161
Merged
Fix dismiss post bug #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where tapping the new-post button creates the new local draft, but doesn’t automatically load it in the post editor until you open, and then dismiss, the settings sheet.
thebaer
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73.
This PR will probably have some conflicts with #160, but otherwise removes the GeometryReader that was being used to set the width of the bottom toolbar — this was causing the dismissed post to be pushed back onto the navigation stack when the post list re-rendered. To replicate the bottom bar layout, I replaced it with a simple view that presents the same elements: the settings button, the number of posts in the list, and the refresh button. The only tricksy thing we're doing here is setting the height of the frame based on the safeAreaInset, to make sure that it clears the home navigation bar on devices that don't have a physical home button:
Compared with a phone that has a physical home button: